Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Make unique headings #341

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Docs: Make unique headings #341

merged 3 commits into from
Aug 17, 2023

Conversation

christophfroehlich
Copy link
Contributor

To use autosection labels, we need unique headings within the same document.

@christophfroehlich
Copy link
Contributor Author

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Aug 14, 2023 •
edited
Loading

backport humble

✅ Backports have been created

@christophfroehlich christophfroehlich mentioned this pull request Aug 16, 2023
Merged
@bmagyar bmagyar merged commit c6e813a into ros-controls:master Aug 17, 2023
14 checks passed
mergify bot pushed a commit that referenced this pull request Aug 17, 2023
@christophfroehlich @mergify
Docs: Make unique headings (#341)
cd0f8b6 
* Make unique headings

* Update docker installation

* Revert "Update docker installation"

This reverts commit 54ccdb6.

(cherry picked from commit c6e813a)
@mergify mergify bot mentioned this pull request Aug 17, 2023
Merged
@christophfroehlich christophfroehlich deleted the link_section branch August 17, 2023 12:47
christophfroehlich pushed a commit that referenced this pull request Aug 17, 2023
@mergify
Docs: Make unique headings (#341) (#348)
54a3ae4
moriarty
moriarty reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@moriarty moriarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moriarty
Copy link
Contributor

opps 😆 I was just closing all my tabs didn't I guess I had a tab with LGTM comment

@bmagyar
Copy link
Member

bmagyar commented Aug 18, 2023

Better late than never! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moriarty moriarty moriarty left review comments

@bmagyar bmagyar bmagyar approved these changes

@aprotyas aprotyas Awaiting requested review from aprotyas

@DasRoteSkelett DasRoteSkelett Awaiting requested review from DasRoteSkelett

@duringhof duringhof Awaiting requested review from duringhof

@erickisos erickisos Awaiting requested review from erickisos

@VanshGehlot VanshGehlot Awaiting requested review from VanshGehlot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christophfroehlich @moriarty @bmagyar